Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
JSON::Validator 3 changes #45
format functions must return
Coerce to real JSON booleans, not 'true'/'false' as JV fixed a bug. Previously coercion did not coerce ie mutate the passed-in values, now it does and it doesn't recognise the strings as boolean values.
Also update the deps, and eliminate a surprising duplicate
I added a commit that removes the need for Cpanel::JSON::XS by changing the test's data, but I have no clue why my commit works. I would've expected that if I were to have changed all the
I think we may need to clean up our handling of booleans internally to try to normalize to
Does this additional commit make any sense to you? Because it doesn't to me. All I know is it passes the test and for that I'm okay with releasing it if you are.
No, I'm wrong: We would need a test with Cpanel::JSON::XS, since Mojo::JSON prefers it in cases where it exists. The 5.14 test was failing without Cpanel::JSON::XS, which made it fall back to Mojo::JSON and JSON::PP::Boolean booleans... Either way, that's not important for this. Let's ship it!