Conversation
JSON::Validator::OpenAPI is gone, use JSON::Validator::OpenAPI::Mojolicious format functions must return undef when ok Coerce to real JSON booleans, not 'true'/'false' as JV fixed a bug. Previously coercion did not work right, now it does and it doesn't recognise the strings as boolean values.
This is weird. I don't know why these particular values need to be boolean objects instead of 0/1. I would have expected all of the values to be boolean objects now that output is being coerced, but that's not what is happening here...
|
I added a commit that removes the need for Cpanel::JSON::XS by changing the test's data, but I have no clue why my commit works. I would've expected that if I were to have changed all the I think we may need to clean up our handling of booleans internally to try to normalize to Does this additional commit make any sense to you? Because it doesn't to me. All I know is it passes the test and for that I'm okay with releasing it if you are. |
|
Also, we may need to add a specific Travis build with |
|
The extra commit makes sense to me, and is similar to what I tried. Yes, agreed with the Devel::Hide thing. Are you happy to do that or should I? |
|
No, I'm wrong: We would need a test with Cpanel::JSON::XS, since Mojo::JSON prefers it in cases where it exists. The 5.14 test was failing without Cpanel::JSON::XS, which made it fall back to Mojo::JSON and JSON::PP::Boolean booleans... Either way, that's not important for this. Let's ship it! |
|
... and Mojo::JSON always uses JSON::PP::true and JSON::PP::false... Curiouser and curiouser... |
[Added]
- Added some more intelligent inferences about a configured OpenAPI
spec to hook up the controller. In short: It's now easier to
provide your own OpenAPI spec to work with the Yancy editor.
Thanks @mohawk2 for continuing this work! [Github #43]
[Fixed]
- Fixed compatibility with JSON::Validator version 3. Thanks
@mohawk2 for the patch! [Github #45] Thanks @eserte for the report
[Github #44]
|
This was caused by jhthorsen/json-validator#145 |
JSON::Validator::OpenAPIis gone, useJSON::Validator::OpenAPI::Mojoliciousformat functions must return
undefwhen okCoerce to real JSON booleans, not 'true'/'false' as JV fixed a bug. Previously coercion did not coerce ie mutate the passed-in values, now it does and it doesn't recognise the strings as boolean values.
Also update the deps, and eliminate a surprising duplicate
blogspec int/helpers.t.Fixes #44.