Allow rendering in document by JoviDeCroock · Pull Request #4564 · preactjs/preact

JoviDeCroock · 2024-11-22T15:46:19Z

Resolves #3794

When we want to render straight into document we have to alias it to .documentElement as this is used in Remix we could consider supporting it, or moving it to compat.

github-actions · 2024-11-22T15:47:39Z

Size Change: +101 B (+0.16%)

Total Size: 62.5 kB

Filename	Size	Change
`dist/preact.js`	4.74 kB	+17 B (+0.36%)
`dist/preact.min.js`	4.75 kB	+17 B (+0.36%)
`dist/preact.min.module.js`	4.76 kB	+19 B (+0.4%)
`dist/preact.min.umd.js`	4.78 kB	+16 B (+0.34%)
`dist/preact.module.js`	4.76 kB	+15 B (+0.32%)
`dist/preact.umd.js`	4.79 kB	+17 B (+0.36%)

ℹ️ View Unchanged

Filename	Size
`compat/dist/compat.js`	4.13 kB
`compat/dist/compat.module.js`	4.06 kB
`compat/dist/compat.umd.js`	4.19 kB
`debug/dist/debug.js`	3.82 kB
`debug/dist/debug.module.js`	3.83 kB
`debug/dist/debug.umd.js`	3.9 kB
`devtools/dist/devtools.js`	260 B
`devtools/dist/devtools.module.js`	274 B
`devtools/dist/devtools.umd.js`	346 B
`hooks/dist/hooks.js`	1.52 kB
`hooks/dist/hooks.module.js`	1.56 kB
`hooks/dist/hooks.umd.js`	1.6 kB
`jsx-runtime/dist/jsxRuntime.js`	973 B
`jsx-runtime/dist/jsxRuntime.module.js`	947 B
`jsx-runtime/dist/jsxRuntime.umd.js`	1.05 kB
`test-utils/dist/testUtils.js`	451 B
`test-utils/dist/testUtils.module.js`	456 B
`test-utils/dist/testUtils.umd.js`	536 B

_{compressed-size-action}

github-actions · 2024-11-22T15:48:23Z

📊 Tachometer Benchmark Results

Summary

⏳ Benchmarks are currently running. Results below are out of date.

duration

create10k: unsure 🔍 -0% - +1% (-4.49ms - +5.40ms)
^{preact-local vs preact-main}
filter-list: unsure 🔍 -0% - +0% (-0.02ms - +0.07ms)
^{preact-local vs preact-main}
hydrate1k: unsure 🔍 -1% - +2% (-0.86ms - +1.43ms)
^{preact-local vs preact-main}
many-updates: unsure 🔍 -2% - +6% (-0.39ms - +1.03ms)
^{preact-local vs preact-main}
replace1k: unsure 🔍 -1% - +1% (-1.03ms - +0.85ms)
^{preact-local vs preact-main}
text-update: unsure 🔍 -2% - +7% (-0.03ms - +0.15ms)
^{preact-local vs preact-main}
todo: unsure 🔍 -1% - +0% (-0.44ms - +0.10ms)
^{preact-local vs preact-main}
update10th1k: unsure 🔍 -5% - +2% (-1.67ms - +0.76ms)
^{preact-local vs preact-main}

usedJSHeapSize

create10k: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
^{preact-local vs preact-main}
filter-list: unsure 🔍 -0% - +1% (-0.01ms - +0.02ms)
^{preact-local vs preact-main}
hydrate1k: unsure 🔍 -5% - +3% (-0.65ms - +0.45ms)
^{preact-local vs preact-main}
many-updates: unsure 🔍 -0% - +0% (-0.01ms - +0.02ms)
^{preact-local vs preact-main}
replace1k: slower ❌ 0% - 1% (0.01ms - 0.04ms)
^{preact-local vs preact-main}
text-update: unsure 🔍 -0% - +1% (-0.00ms - +0.01ms)
^{preact-local vs preact-main}
todo: unsure 🔍 -1% - +1% (-0.01ms - +0.01ms)
^{preact-local vs preact-main}
update10th1k: unsure 🔍 -1% - +0% (-0.03ms - +0.00ms)
^{preact-local vs preact-main}

Results

⏳ Benchmarks are currently running. Results below are out of date.

create10k

Browser: chrome-headless
Sample size: 50
Built by: CI #4067
Commit: e833b97

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	942.16ms - 951.31ms	-	unsure 🔍 -0% - +1% -4.49ms - +5.40ms
preact-main	944.40ms - 948.15ms	unsure 🔍 -1% - +0% -5.40ms - +4.49ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	24.84ms - 24.84ms	-	unsure 🔍 -0% - +0% -0.01ms - +0.00ms
preact-main	24.84ms - 24.85ms	unsure 🔍 -0% - +0% -0.00ms - +0.01ms	-

filter-list

Browser: chrome-headless
Sample size: 50
Built by: CI #4067
Commit: e833b97

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.56ms - 16.60ms	-	unsure 🔍 -0% - +0% -0.02ms - +0.07ms
preact-main	16.52ms - 16.60ms	unsure 🔍 -0% - +0% -0.07ms - +0.02ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.65ms - 1.68ms	-	unsure 🔍 -0% - +1% -0.01ms - +0.02ms
preact-main	1.65ms - 1.66ms	unsure 🔍 -1% - +0% -0.02ms - +0.01ms	-

hydrate1k

Browser: chrome-headless
Sample size: 90
Built by: CI #4067
Commit: e833b97

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	73.06ms - 75.06ms	-	unsure 🔍 -1% - +2% -0.86ms - +1.43ms
preact-main	73.22ms - 74.33ms	unsure 🔍 -2% - +1% -1.43ms - +0.86ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	13.48ms - 14.28ms	-	unsure 🔍 -5% - +3% -0.65ms - +0.45ms
preact-main	13.60ms - 14.36ms	unsure 🔍 -3% - +5% -0.45ms - +0.65ms	-

many-updates

Browser: chrome-headless
Sample size: 90
Built by: CI #4067
Commit: e833b97

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.52ms - 17.40ms	-	unsure 🔍 -2% - +6% -0.39ms - +1.03ms
preact-main	16.09ms - 17.20ms	unsure 🔍 -6% - +2% -1.03ms - +0.39ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	4.50ms - 4.52ms	-	unsure 🔍 -0% - +0% -0.01ms - +0.02ms
preact-main	4.50ms - 4.51ms	unsure 🔍 -0% - +0% -0.02ms - +0.01ms	-

replace1k

Browser: chrome-headless
Sample size: 90
Built by: CI #4067
Commit: e833b97

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	71.75ms - 72.96ms	-	unsure 🔍 -1% - +1% -1.03ms - +0.85ms
preact-main	71.73ms - 73.17ms	unsure 🔍 -1% - +1% -0.85ms - +1.03ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	3.56ms - 3.59ms	-	slower ❌ 0% - 1% 0.01ms - 0.04ms
preact-main	3.54ms - 3.56ms	faster ✔ 0% - 1% 0.01ms - 0.04ms	-

run-warmup-0

Version	Avg time	vs preact-local	vs preact-main
preact-local	31.69ms - 32.47ms	-	unsure 🔍 -1% - +3% -0.28ms - +0.85ms
preact-main	31.38ms - 32.20ms	unsure 🔍 -3% - +1% -0.85ms - +0.28ms	-

run-warmup-1

Version	Avg time	vs preact-local	vs preact-main
preact-local	37.70ms - 39.05ms	-	unsure 🔍 -2% - +3% -0.96ms - +1.02ms
preact-main	37.62ms - 39.07ms	unsure 🔍 -3% - +2% -1.02ms - +0.96ms	-

run-warmup-2

Version	Avg time	vs preact-local	vs preact-main
preact-local	31.46ms - 32.62ms	-	unsure 🔍 -2% - +3% -0.61ms - +0.91ms
preact-main	31.40ms - 32.38ms	unsure 🔍 -3% - +2% -0.91ms - +0.61ms	-

run-warmup-3

Version	Avg time	vs preact-local	vs preact-main
preact-local	23.80ms - 24.31ms	-	unsure 🔍 -3% - +0% -0.70ms - +0.02ms
preact-main	24.14ms - 24.65ms	unsure 🔍 -0% - +3% -0.02ms - +0.70ms	-

run-warmup-4

Version	Avg time	vs preact-local	vs preact-main
preact-local	22.89ms - 23.21ms	-	unsure 🔍 -1% - +1% -0.31ms - +0.22ms
preact-main	22.89ms - 23.31ms	unsure 🔍 -1% - +1% -0.22ms - +0.31ms	-

run-final

Version	Avg time	vs preact-local	vs preact-main
preact-local	21.17ms - 21.81ms	-	unsure 🔍 -2% - +2% -0.40ms - +0.53ms
preact-main	21.09ms - 21.76ms	unsure 🔍 -2% - +2% -0.53ms - +0.40ms	-

text-update

Browser: chrome-headless
Sample size: 220
Built by: CI #4067
Commit: e833b97

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	2.11ms - 2.24ms	-	unsure 🔍 -2% - +7% -0.03ms - +0.15ms
preact-main	2.05ms - 2.18ms	unsure 🔍 -7% - +2% -0.15ms - +0.03ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.11ms - 1.11ms	-	unsure 🔍 -0% - +1% -0.00ms - +0.01ms
preact-main	1.10ms - 1.11ms	unsure 🔍 -1% - +0% -0.01ms - +0.00ms	-

todo

Browser: chrome-headless
Sample size: 50
Built by: CI #4067
Commit: e833b97

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	33.58ms - 33.80ms	-	unsure 🔍 -1% - +0% -0.44ms - +0.10ms
preact-main	33.61ms - 34.10ms	unsure 🔍 -0% - +1% -0.10ms - +0.44ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.22ms - 1.23ms	-	unsure 🔍 -1% - +1% -0.01ms - +0.01ms
preact-main	1.22ms - 1.23ms	unsure 🔍 -1% - +1% -0.01ms - +0.01ms	-

update10th1k

Browser: chrome-headless
Sample size: 50
Built by: CI #4067
Commit: e833b97

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	33.28ms - 34.74ms	-	unsure 🔍 -5% - +2% -1.67ms - +0.76ms
preact-main	33.49ms - 35.44ms	unsure 🔍 -2% - +5% -0.76ms - +1.67ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	3.47ms - 3.49ms	-	unsure 🔍 -1% - +0% -0.03ms - +0.00ms
preact-main	3.48ms - 3.51ms	unsure 🔍 -0% - +1% -0.00ms - +0.03ms	-

_{tachometer-reporter-action v2 for CI}

coveralls · 2024-11-22T15:49:00Z

coverage: 99.488%. remained the same
when pulling c08c63e on allow-rendering-in-doc
into 5b6c3a5 on main.

marvinhagemeister

LGTM, lets add a test if possible

JoviDeCroock · 2024-11-22T16:01:20Z

@marvinhagemeister Yes, sorry was a bit quick here was stuck on the test as I needed to change something in the tests first

rschristian

I don't suppose Remix is willing to switch to using document.documentElement? Seems a bit odd to use plain document.

This reverts commit 269cdd8.

JoviDeCroock requested review from marvinhagemeister and rschristian November 22, 2024 15:46

marvinhagemeister reviewed Nov 22, 2024

View reviewed changes

JoviDeCroock requested a review from marvinhagemeister November 22, 2024 16:00

marvinhagemeister approved these changes Nov 22, 2024

View reviewed changes

rschristian approved these changes Nov 22, 2024

View reviewed changes

JoviDeCroock added 2 commits November 23, 2024 09:23

Allow rendering in document

5d693ae

Add test

e833b97

JoviDeCroock force-pushed the allow-rendering-in-doc branch from 3aba943 to e833b97 Compare November 23, 2024 08:23

Merge branch 'main' into allow-rendering-in-doc

c08c63e

JoviDeCroock merged commit 269cdd8 into main Nov 24, 2024

JoviDeCroock deleted the allow-rendering-in-doc branch November 24, 2024 08:17

upupming added a commit to upupming/preact that referenced this pull request Dec 24, 2025

Revert "Allow rendering in document (preactjs#4564)"

4c6a8b4

This reverts commit 269cdd8.

upupming added a commit to upupming/preact that referenced this pull request Jan 4, 2026

Revert "Allow rendering in document (preactjs#4564)"

c6477a3

This reverts commit 269cdd8.

upupming added a commit to upupming/preact that referenced this pull request Jan 4, 2026

Revert "Allow rendering in document (preactjs#4564)"

db4d8bf

This reverts commit 269cdd8.

upupming added a commit to upupming/preact that referenced this pull request Mar 2, 2026

Revert "Allow rendering in document (preactjs#4564)"

961fabb

This reverts commit 269cdd8.

Uh oh!

Conversation

JoviDeCroock commented Nov 22, 2024

Uh oh!

github-actions bot commented Nov 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

duration

usedJSHeapSize

Results

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

run-warmup-0

run-warmup-1

run-warmup-2

run-warmup-3

run-warmup-4

run-final

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

Uh oh!

coveralls commented Nov 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marvinhagemeister left a comment

Choose a reason for hiding this comment

Uh oh!

JoviDeCroock commented Nov 22, 2024

Uh oh!

rschristian left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Nov 22, 2024 •

edited

Loading

github-actions bot commented Nov 22, 2024 •

edited

Loading

coveralls commented Nov 22, 2024 •

edited

Loading