fix: Correct defaultValue property types for inputs, selects, & textareas#4585
Merged
JoviDeCroock merged 3 commits intomainfrom Nov 30, 2024
Merged
fix: Correct defaultValue property types for inputs, selects, & textareas#4585JoviDeCroock merged 3 commits intomainfrom
defaultValue property types for inputs, selects, & textareas#4585JoviDeCroock merged 3 commits intomainfrom
Conversation
rschristian
changed the title
defaultValue property to textareasdefaultValue property to textareas & selects
rschristian
changed the title
defaultValue property to textareas & selectsdefaultValue property type to textareas & selects
rschristian
changed the title
defaultValue property type to textareas & selectsdefaultValue property types for inputs, selects, & textareas
rschristian
commented
Nov 30, 2024
| checked?: Signalish<boolean | undefined>; | ||
| defaultChecked?: Signalish<boolean | undefined>; | ||
| defaultValue?: Signalish<string | undefined>; | ||
| defaultValue?: Signalish<string | number | undefined>; |
Member
Author
There was a problem hiding this comment.
Not supported in our old types, but I think it should be? Nothing wrong with input.defaultValue = 2.
JoviDeCroock
approved these changes
Nov 30, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.