fix: Remove postinstall script for playwright setup#5063
Merged
rschristian merged 1 commit intov10.xfrom Mar 25, 2026
Merged
Conversation
rschristian
commented
Mar 24, 2026
| "dev:hooks": "microbundle watch --raw --no-generateTypes --format cjs --cwd hooks", | ||
| "dev:compat": "microbundle watch --raw --no-generateTypes --format cjs --cwd compat --globals 'preact/hooks=preactHooks'", | ||
| "test": "npm-run-all build lint test:unit", | ||
| "test:install": "playwright install chromium", |
Member
Author
There was a problem hiding this comment.
There didn't seem to be an obvious need for --with-deps so I elected to match main's setup:
Line 134 in 21dd6d0
rschristian
requested review from
JoviDeCroock and
marvinhagemeister
and removed request for
marvinhagemeister
Member
Author
|
^ Dunno what I did to request reviews & immediately un-request Marvin, wasn't intentional. Sorry for the pings! |
JoviDeCroock
approved these changes
Mar 25, 2026
marvinhagemeister
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missed in #5060
postinstallscripts run after the dependency was installed, not just when installing deps in the repo. As such, this would've broken anynpm install preactinto a project that wasn't using playwright.Caught by our ecosystem-ci yesterday and again today: