Version Packages#612
Open
github-actions[bot] wants to merge 1 commit intomainfrom
Open
Conversation
53f2cbe to
d9dc036
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@prefresh/core@1.5.10
Patch Changes
f6129bbef1db5db70e292b56a6b8fff734ba2cc2#613 Thanks @JoviDeCroock! - AlignBoth Babel and Oxc emit two
_s(…, key)calls for a memo-wrapped component(
_s(memo(_c = _s(inner, key)), key)). The previous status-machine approachmishandled the second keyed call, crashing with "Cannot set properties of
undefined" because the outer type had not yet been registered when
signwascalled with
'needsHooks'.The new implementation follows the same pattern as
createSignatureFunctionForTransforminvite-plugin-react:typeof key === 'string'instead of a mutablestatusvariable.signwith'begin'for every keyed call, regardless of positionin the HOC chain.
savedType(the innermost type) and defer'needsHooks'collection tothe first no-argument body call, guarded by a
didCollectHooksflag.@prefresh/core'ssignis also made idempotent on the'begin'path so thatthe inner type's
getCustomHooksis never overwritten by an outer HOC call thatcarries no hook information, and the
'needsHooks'path is guarded against amissing signature entry.
@prefresh/vite@3.0.1
Patch Changes
ba9db171417a3f9eb5726763eb693ca3f0cdce0d#611 Thanks @JoviDeCroock! - Add workaround for Oxc transforming differently than babelf6129bbef1db5db70e292b56a6b8fff734ba2cc2#613 Thanks @JoviDeCroock! - AlignBoth Babel and Oxc emit two
_s(…, key)calls for a memo-wrapped component(
_s(memo(_c = _s(inner, key)), key)). The previous status-machine approachmishandled the second keyed call, crashing with "Cannot set properties of
undefined" because the outer type had not yet been registered when
signwascalled with
'needsHooks'.The new implementation follows the same pattern as
createSignatureFunctionForTransforminvite-plugin-react:typeof key === 'string'instead of a mutablestatusvariable.signwith'begin'for every keyed call, regardless of positionin the HOC chain.
savedType(the innermost type) and defer'needsHooks'collection tothe first no-argument body call, guarded by a
didCollectHooksflag.@prefresh/core'ssignis also made idempotent on the'begin'path so thatthe inner type's
getCustomHooksis never overwritten by an outer HOC call thatcarries no hook information, and the
'needsHooks'path is guarded against amissing signature entry.
Updated dependencies [
f6129bbef1db5db70e292b56a6b8fff734ba2cc2]: