Closed
Conversation
Merged
rschristian
reviewed
Mar 15, 2026
Comment on lines
+178
to
+179
| // Vite 8 renamed `rollupOptions` to `rolldownOptions` :( -> fall back to rollupOptions for Vite 5–7 | ||
| const _buildOpts = config.build.rolldownOptions ?? config.build.rollupOptions; |
Member
There was a problem hiding this comment.
Unless it's absolutely needed, and it doesn't appear to be, I don't want to do this.
Comment on lines
-240
to
+242
| `const relList = document.createElement('link').relList;`, | ||
| /const relList = document\.createElement\(["']link["']\)\.relList;?/, |
Member
There was a problem hiding this comment.
As mentioned, this is just a slower, harder to debug, and less documented combination of the 3 distinct branches. No thanks.
| /** @type {Partial<import('./types.d.ts').Head>} */ | ||
| let head = { lang: '', title: '', elements: new Set() }; | ||
|
|
||
| // Vite 8 native Rolldown path: modulepreload polyfill is injected by rolldown/experimental |
Member
There was a problem hiding this comment.
I don't know what "native Rolldown path:" is supposed to mean, or what "rolldown/experimental" is
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.