Skip to content

gppControl modules: add missing transmitUfpd check#14604

Merged
patmmccann merged 2 commits intomasterfrom
fix-gpp-transmitUfpd
Mar 17, 2026
Merged

gppControl modules: add missing transmitUfpd check#14604
patmmccann merged 2 commits intomasterfrom
fix-gpp-transmitUfpd

Conversation

@dgirardi
Copy link
Collaborator

Type of change

  • Bugfix

Description of change

According to the spec, gppControl_usnat and gppControl_usstates should set up two different rules on enrichUfpd and transmitUfpd.
Instead, the current version is using the transmitUfpd logic for enrichEid, and not doing any check on transmitUfpd.

Fixes #14601

@coveralls
Copy link
Collaborator

coveralls commented Mar 17, 2026

Pull Request Test Coverage Report for Build 23210410175

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 96.345%

Totals Coverage Status
Change from base Build 23109247465: 0.002%
Covered Lines: 215637
Relevant Lines: 223818

💛 - Coveralls

@patmmccann patmmccann merged commit 6295bfb into master Mar 17, 2026
10 checks passed
@patmmccann patmmccann deleted the fix-gpp-transmitUfpd branch March 17, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GPP Control Module Limitation for transmitUfpd in Bidder Requests configured through setConfig or mergeConfig

3 participants