ssp_genieeBidAdapter add param schain and floor price#14674
ssp_genieeBidAdapter add param schain and floor price#14674patmmccann merged 56 commits intoprebid:masterfrom
Conversation
fix imuid module
- Add support for GPID (Global Placement ID) from ortb2Imp.ext.gpid - Add fallback support for ortb2Imp.ext.data.pbadslot - Include gpid parameter in request when GPID exists - Add test cases to verify GPID, pbadslot, and priority behavior
feat(Ssp_geniee Bid Adapter): Add support for GPID and pbadslot
Sync prebid origin
Aladdin Bidder ID5 Compatible Adapter
feat(Ssp_geniee Bid Adapter): Add support for iframe-based cookie sync in BidAdapter
Hotfix/carpet 4748
- change default value ib parameter
…fault-value-of-ib-parameter [CARPET-5190] Bid Adapter: Fix the default value of the ib parameter
prebid:masterの取り込み
Update master
Update master
reset document.title after test
…ic-of-specified-currency-bidparams [CARPET-6134] Change logic of specified currency bid-params
…loor-price-to-aladidin-bidder Feature/add param schain and floor price to aladidin bidder
Feature/update uptream prebidjs
thanhtran-geniee
changed the title
thanhtran-geniee
changed the title
|
Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9750bc2c45
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
modules/ssp_genieeBidAdapter.js
Outdated
| cks: 1, | ||
| schain: schain ? JSON.stringify(schain) : '', | ||
| ...(gpid ? { gpid } : {}), | ||
| ...(floorPrice ? { fl_pr: floorPrice } : {}), |
There was a problem hiding this comment.
Include fl_pr whenever getFloorPrice returns a numeric value, including 0. The current truthy check drops fl_pr when the floor module returns 0 (a valid floor/fallback), which changes request semantics for those impressions and can cause the bidder endpoint to apply its own default floor instead of the publisher’s explicit zero floor.
Useful? React with 👍 / 👎.
Pull Request Test Coverage Report for Build 24017873017Details
💛 - Coveralls |
…ice-aceept-value-zero hotfix accept send floor price value zero aladdin bidder
|
Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):
|
Feature/sync upstream master
9 participants
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Update
ssp_genieeBidAdapterto add a new parameterschainandfl_prBe sure to test the integration with your adserver using the Hello World sample page. -->
Other information