Magnite Bid Adapter: support params.floor like rubiconBidAdapter#14694
Magnite Bid Adapter: support params.floor like rubiconBidAdapter#14694patmmccann merged 5 commits intomasterfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6652a649cd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Adds impression-level bid floor support to the Magnite bid adapter (matching Rubicon’s params.floor behavior) as a fallback when the Price Floors module / getFloor() does not populate imp.bidfloor.
Changes:
- Add
params.floorfallback logic to setimp.bidfloor/imp.bidfloorcur(USD) when ORTB conversion didn’t set a USD floor. - Add unit tests covering precedence between
getFloor()andparams.floor, non-USD handling, and invalid string input. - Document the new
floorbid param and how it interacts with the Price Floors module.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| modules/magniteBidAdapter.js | Implements params.floor fallback and adjusts the ORTB bidfloor override naming. |
| test/spec/modules/magniteBidAdapter_spec.js | Adds tests for imp.bidfloor population behavior. |
| modules/magniteBidAdapter.md | Documents floor param and bid floor resolution order. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage Report for CI Build 24347494326Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage increased (+33.2%) to 96.344%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions38 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Type of change
Description of change
We are adding support for param level floor for Magnite Bid Adapter to keep it similar to Rubicon Bid Adapter.
It is only used if ORTB Converter does not resolve a floor (Price Floors getFloor usually)