Skip to content

Fluct Bid Adapter: Correct bid endpoint URL#14696

Merged
patmmccann merged 2 commits intoprebid:masterfrom
yowcow:fix-fluct-bid-endpoint-url
Apr 13, 2026
Merged

Fluct Bid Adapter: Correct bid endpoint URL#14696
patmmccann merged 2 commits intoprebid:masterfrom
yowcow:fix-fluct-bid-endpoint-url

Conversation

@yowcow
Copy link
Copy Markdown
Contributor

@yowcow yowcow commented Apr 10, 2026

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Fluct endpoint path correction (/prebid/prebid/)

Other information

Copilot AI review requested due to automatic review settings April 10, 2026 02:58
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Fluct bidder adapter’s request URL to use the corrected endpoint path by adding a trailing slash.

Changes:

  • Updated END_POINT from https://hb.adingo.jp/prebid to https://hb.adingo.jp/prebid/ to match the corrected endpoint path.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


const BIDDER_CODE = 'fluct';
const END_POINT = 'https://hb.adingo.jp/prebid';
const END_POINT = 'https://hb.adingo.jp/prebid/';
Copy link

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change updates END_POINT to include a trailing slash, which changes the built request URL to https://hb.adingo.jp/prebid/?.... There is an existing unit test in test/spec/modules/fluctBidAdapter_spec.js that currently asserts the old URL without the slash, so the test suite will fail unless it’s updated to match the new endpoint format.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed 🙏 → cfbf6fe

@coveralls
Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 24225975702

Coverage decreased (-0.001%) to 96.343%

Details

  • Coverage decreased (-0.001%) from the base build.
  • Patch coverage: 2 of 2 lines across 2 files are fully covered (100%).
  • 2 coverage regressions across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

2 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
libraries/medianetUtils/logger.js 2 83.78%

Coverage Stats

Coverage Status
Relevant Lines: 224980
Covered Lines: 216753
Line Coverage: 96.34%
Relevant Branches: 52487
Covered Branches: 42633
Branch Coverage: 81.23%
Branches in Coverage %: No
Coverage Strength: 71.08 hits per line

💛 - Coveralls

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@patmmccann patmmccann merged commit 442fa3f into prebid:master Apr 13, 2026
105 of 106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants