Skip to content

Sparteo Bid Adapter: fix consent handling#14704

Merged
patmmccann merged 1 commit intoprebid:masterfrom
Viously:sparteo-bid-adapter-consent-and-cleanup
Apr 13, 2026
Merged

Sparteo Bid Adapter: fix consent handling#14704
patmmccann merged 1 commit intoprebid:masterfrom
Viously:sparteo-bid-adapter-consent-and-cleanup

Conversation

@tanguylemeur-sparteo
Copy link
Copy Markdown
Contributor

Hi Team :-)

Please, we would like to submit this update to our Bid Adapter.

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

fix consent handling, vastUrl clobber, params mutation, and dead code

  • Add GPP consent support to getUserSyncs (5th parameter)
  • Fix USP consent: treat as plain string, not object (matching Prebid contract)
  • Encode USP value with encodeURIComponent for consistency
  • Fix vastUrl being clobbered to null when no cache URL exists (preserve ortbConverter nurl fallback)
  • Shallow-copy bidRequest.params to avoid mutating the original object
  • Remove dead site+app conflict resolution (ortbConverter's clientSectionChecker already handles this)
  • Update tests to match all fixes

…tation, and dead code

- Add GPP consent support to getUserSyncs (5th parameter)
- Fix USP consent: treat as plain string, not object (matching Prebid contract)
- Encode USP value with encodeURIComponent for consistency
- Fix vastUrl being clobbered to null when no cache URL exists (preserve ortbConverter nurl fallback)
- Shallow-copy bidRequest.params to avoid mutating the original object
- Remove dead site+app conflict resolution (ortbConverter's clientSectionChecker already handles this)
- Update tests to match all fixes
@review-assignment-bot review-assignment-bot bot requested a review from gwhigs April 13, 2026 13:28
@coveralls
Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 24345896712

Coverage remained the same at 96.343%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: 25 of 25 lines across 2 files are fully covered (100%).
  • 1 coverage regression across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File Lines Losing Coverage Coverage
src/utils.js 1 92.17%

Coverage Stats

Coverage Status
Relevant Lines: 224958
Covered Lines: 216732
Line Coverage: 96.34%
Relevant Branches: 52476
Covered Branches: 42619
Branch Coverage: 81.22%
Branches in Coverage %: No
Coverage Strength: 71.1 hits per line

💛 - Coveralls

@patmmccann patmmccann merged commit 7435f70 into prebid:master Apr 13, 2026
102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants