Core: reduce allocations in metrics.getMetrics#14769
Merged
patmmccann merged 1 commit intomasterfrom Apr 22, 2026
Merged
Conversation
Collaborator
Coverage Report for CI Build 24765613806Coverage increased (+0.001%) to 96.39%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
dgirardi
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
getMetrics()allocated a new object for each visited node during depth-first traversal which increased GC pressure on hot paths that repeatedly call metrics aggregation.Description
Object.assign({}, ...)allocations with a single mutable accumulator object and guarded writes viahasOwnPropertyso nearest metrics keep precedence andincludeGroupsbehavior is preserved.src/utils/perfMetrics.ts(metrics aggregation path only).Testing
npx eslint --cache --cache-strategy content src/utils/perfMetrics.ts test/spec/unit/utils/perfMetrics_spec.jsand it passed.npx gulp test --nolint --file test/spec/unit/utils/perfMetrics_spec.jsand the spec suite passed (49 tests completed).Codex Task