Skip to content

use bid request bidId for sovrn imp.id#379

Merged
mkendall07 merged 3 commits intomasterfrom
bugfix/sovrn-impid
May 27, 2016
Merged

use bid request bidId for sovrn imp.id#379
mkendall07 merged 3 commits intomasterfrom
bugfix/sovrn-impid

Conversation

@protonate
Copy link
Collaborator

No description provided.

@protonate
Copy link
Collaborator Author

@mkendall07 please review & test

@mkendall07
Copy link
Contributor

@cliffliang & @pdramos1
It looks like our test placement is no longer receiving bids (tagid: "315045") - can you guys activate it again so we can validate the fix. Looks like the adapter is currently broken in master. Thanks!

@tcasson303
Copy link

We've updated 315045 so it pulls back a $0.01 CPM bid when called from any domain.

@mkendall07
Copy link
Contributor

@tcasson303

Thanks! Seeing bids back now. Small issue, not a blocker, the creative that comes back serves from this URL, which appears to be internal only http://www.lijit.com/res/images/houseart/2093_9-1394142045.gif.

@tcasson303
Copy link

@mkendall07 mkendall07 merged commit dd17780 into master May 27, 2016
@protonate protonate deleted the bugfix/sovrn-impid branch May 31, 2016 18:51
protonate pushed a commit that referenced this pull request Jun 15, 2016
* use bid request bidId for sovrn imp.id

* fixed placement undefined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants