Fix issue with nginead response not being registered.#380
Merged
mkendall07 merged 3 commits intomasterfrom May 26, 2016
Merged
Conversation
src/adapters/nginad.js
Outdated
| //assign the first adUnit (placement) for bad bids; | ||
| defaultPlacementForBadBid = bidReqs[0].placementCode; | ||
|
|
||
| var requestIdentifier = bidReqs[0].requestId; |
Collaborator
There was a problem hiding this comment.
This can be removed as unused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
bid.params.impIdidentifier never existed on the bid. Use the internalbid.requestIdto match to the callback id. @protonate