Merged
Conversation
schernysh
suggested changes
Oct 31, 2018
| @AllArgsConstructor | ||
| @Configuration | ||
| @EnableConfigurationProperties | ||
| @ConditionalOnProperty(prefix = "spring.aerospike", name = {"endpoint"}, havingValue = "true") |
Contributor
There was a problem hiding this comment.
There is no need for a new endpoint property since there is a couple of other required properties that could be used instead, for example host, same for redis
Contributor
Author
There was a problem hiding this comment.
for now in application.yml we have properties for both.
Contributor
Author
There was a problem hiding this comment.
aerospike and redis
Contributor
There was a problem hiding this comment.
I believe it is something that has to change. It's only in local profile so either aerospike or redis configuration could be left and another removed.
| import java.util.List; | ||
| import java.util.Objects; | ||
|
|
||
| @Repository("aerospike") |
Contributor
There was a problem hiding this comment.
There is no need for qualifier I think
schernysh
suggested changes
Oct 31, 2018
| cache.profiles.active: aerospike | ||
| cache.aerospike.classname.canonical: org.prebid.cache.repository.aerospike.AerospikeRepositoryImpl | ||
| cache.aerospike.property.configuration.classname: AerospikePropertyConfiguration | ||
| spring.aerospike.endpoint: true |
| cache.profiles.active: redis | ||
| cache.redis.classname.canonical: org.prebid.cache.repository.redis.RedisRepositoryImpl | ||
| cache.redis.property.configuration.classname: RedisPropertyConfiguration | ||
| spring.aerospike.endpoint: false |
| @NoArgsConstructor | ||
| @AllArgsConstructor | ||
| @Configuration | ||
| @ConditionalOnProperty(prefix = "spring.redis", name = {"endpoint"}, havingValue = "true") |
Contributor
There was a problem hiding this comment.
This condition should also be checking host, not endpoint
| spring.redis.password: | ||
| #spring.redis.sentinel.master: mymaster | ||
| #spring.redis.sentinel.nodes: localhost:26379 | ||
| endpoint: false |
| import org.junit.jupiter.api.Test; | ||
| import org.junit.jupiter.api.extension.ExtendWith; | ||
| import org.springframework.beans.factory.annotation.Autowired; | ||
| import org.springframework.beans.factory.annotation.Qualifier; |
added 2 commits
October 31, 2018 17:15
schernysh
approved these changes
Oct 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.