Emit unauthorized writes metric #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Net-burst
force-pushed
the
prepend-account-to-id
branch
from
bbf4cbf to
13d037a
Compare
Net-burst
force-pushed
the
prepend-account-to-id
branch
from
4b8925e to
46c83ba
Compare
Net-burst
changed the title
And1sS
requested changes
Feb 17, 2025
Comment on lines
135
to
137
| if (!isValidApiKey) { | ||
| metricsRecorder.markMeterForTag(metricTagPrefix, MeasurementTag.UNAUTHORIZED_WRITE); | ||
| } |
Collaborator
There was a problem hiding this comment.
Please, move metrics emitting to where current method is used. It will be so confusing to find out at some point that method with naming convention isSomethingTrue does side effects.
And1sS
approved these changes
Feb 19, 2025
CTMBNara
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.