Merged
Conversation
SerhiiNahornyi
changed the title
And1sS
requested changes
Mar 21, 2022
And1sS
previously approved these changes
May 4, 2022
…rest assured with Ktor
Co-authored-by: mhupalo <mhupalo@rubiconproject.com>
Net-burst
force-pushed
the
add-functional-test-framework
branch
from
f3f41ed to
1e1b7f4
Compare
CTMBNara
reviewed
May 6, 2022
Comment on lines
+73
to
+74
| val xmlPayloadTransfer = PayloadTransfer.getDefaultXmlPayloadTransfer() | ||
| xmlPayloadTransfer.key = uuid |
Collaborator
There was a problem hiding this comment.
What about to use apply? Also, please, check for similar occurences.
val xmlPayloadTransfer = PayloadTransfer.getDefaultXmlPayloadTransfer().apply { key = uuid }
| val uuid = getRandomUuid() | ||
| val xmlPayloadTransfer = PayloadTransfer.getDefaultXmlPayloadTransfer() | ||
| xmlPayloadTransfer.key = uuid | ||
| val requestObject = RequestObject(listOf(xmlPayloadTransfer)) |
Collaborator
There was a problem hiding this comment.
What about to add static constructor method to RequestObject which accept vararg of PayloadTransfer?
fun of(vararg puts: PayloadTransfer): RequestObject =
RequestObject(puts = puts.asList())
Than you can don't use every time listOf(...)
Comment on lines
+15
to
+19
| fun getPrebidCacheApi(config: Map<String, String> = prebidCacheConfig.getBaseRedisConfig("false")): PrebidCacheApi { | ||
| val prebidCacheContainer = | ||
| ContainerDependencies.prebidCacheContainerPool.getPrebidCacheContainer(config) | ||
| return PrebidCacheApi(prebidCacheContainer.host, prebidCacheContainer.getHostPort()) | ||
| } |
Collaborator
There was a problem hiding this comment.
What about to replace method body with this approach?
ContainerDependencies.prebidCacheContainerPool.getPrebidCacheContainer(config)
.let { container -> PrebidCacheApi(container.host, container.getHostPort()) }
| webCacheContainerClient.getProxyCacheHostRecordedRequestCount() shouldBe initialProxyCacheHostRequestCount + 1 | ||
|
|
||
| val proxyCacheHostRequest = webCacheContainerClient.getProxyCacheHostRecordedRequests()!!.last() | ||
| proxyCacheHostRequest.queryStringParameters?.containsEntry("uuid", requestUuid) |
Collaborator
There was a problem hiding this comment.
Do there need to be some assertion?
| secondaryCacheRecordedRequests?.size shouldBe 1 | ||
|
|
||
| // and: Request contained secondaryCache=yes query parameter | ||
| secondaryCacheRecordedRequests!!.first().queryStringParameters?.containsEntry("secondaryCache", "yes") |
Collaborator
There was a problem hiding this comment.
Do there need to be some assertion?
Comment on lines
+11
to
+13
| var type: MediaType, | ||
| var key: String? = null, | ||
| var value: String, |
Collaborator
There was a problem hiding this comment.
Fields with default values are usually listed after other fields.
|
|
||
| companion object { | ||
| private val MAX_CONTAINER_COUNT: Int = (System.getProperty("max.containers.count") ?: "3").toInt() | ||
| private val prebidCacheContainerMap: MutableMap<Map<String, String>, PrebidCacheContainer> = mutableMapOf() |
Collaborator
There was a problem hiding this comment.
Does this property need to be static?
| private const val FIXED_EXPOSED_APPLICATION_PORT = 49100 | ||
| private const val FIXED_EXPOSED_DEBUG_PORT = 49101 | ||
|
|
||
| private val USE_FIXED_PORTS = (System.getProperty("useFixedContainerPorts") ?: "false").toBoolean() |
Collaborator
There was a problem hiding this comment.
System.getProperty("useFixedContainerPorts")?.toBoolean() ?: false
Comment on lines
+7
to
+11
| fun getRandomString(length: Int = 16): String { | ||
| val allowedChars = ('A'..'Z') + ('a'..'z') + ('0'..'9') | ||
| return (1..length).map { allowedChars.random() } | ||
| .joinToString("") | ||
| } |
Collaborator
There was a problem hiding this comment.
What about this approach?
List(length) { ALLOWED_CHARS.random() }.joinToString("")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created test framework to cover existing functionality of Prebid Cache with tests written in Kotlin