Conversation
changed min and max expiry violation policy
schernysh
reviewed
Sep 19, 2018
| this.config = config; | ||
| this.builder = builder; | ||
| this.currentDateProvider = currentDateProvider; | ||
| this.minExpiry = config.getMinExpiry(); |
Contributor
There was a problem hiding this comment.
These two values are accessible from config field so why not inline config.get[Max|Min]Expiry() in adjustExpiry()?
| } | ||
|
|
||
| private long adjustExpiry(Long expiry) { | ||
| if(expiry == null) { |
Contributor
There was a problem hiding this comment.
It's a matter of taste maybe but if-else if-else construction may convey logic more concisely.
Contributor
Author
There was a problem hiding this comment.
as for me its more readable and prevent unnecessary nesting
| --- | ||
| spring.profiles: local | ||
| cache.expiry_sec: 300 | ||
| cache.min_expiry: 60 |
Contributor
There was a problem hiding this comment.
Since YAML supports hierarchical representation of parameters same could be expressed (better idiomatically) as follows:
cache:
min_expiry: 60
max_expiry: 28800
| import org.prebid.cache.model.RequestObject; | ||
| import org.prebid.cache.repository.CacheConfig; | ||
| import org.prebid.cache.repository.ReactiveTestAerospikeRepositoryContext; | ||
| import org.prebid.cache.repository.aerospike.AerospikePropertyConfiguration; |
Contributor
There was a problem hiding this comment.
Are these three imports actually used?
schernysh
approved these changes
Sep 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.