added new config option to disallow manual specifying UUID#8
Merged
added new config option to disallow manual specifying UUID#8
Conversation
schernysh
suggested changes
Sep 26, 2018
|
|
||
| private void validateUUID(final PayloadWrapper payload, final SynchronousSink<PayloadWrapper> sink) { | ||
| if(payload.isExternalId() && !config.isAllowExternalUUID()) { | ||
| sink.error(new InvalidUUIDException("You cant specify UUID manually.")); |
Contributor
There was a problem hiding this comment.
It's better to choose another wording like "Prebid cache host forbids specifying UUID in request"
| package org.prebid.cache.handlers; | ||
|
|
||
| import com.google.common.collect.ImmutableList; | ||
| import org.junit.jupiter.api.Nested; |
| @Test | ||
| void testExternalUUIDInvalid() { | ||
| //given | ||
| cacheConfig.setAllowExternalUUID(false); |
Contributor
There was a problem hiding this comment.
I wouldn't do this since Spring Test could cache context and beans between tests so it's better to create new config object just for this test
schernysh
previously approved these changes
Oct 2, 2018
TerentievEvgany
approved these changes
Oct 2, 2018
schernysh
approved these changes
Oct 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added new config option to disallow manual specifying UUID
slightly changed tests for more flexibility