added option to prevent uuid duplications#9
Merged
TerentievEvgany merged 3 commits intomasterfrom Oct 8, 2018
Merged
Conversation
TerentievEvgany
suggested changes
Oct 4, 2018
TerentievEvgany
suggested changes
Oct 5, 2018
| serverMock.stubFor(post(urlPathEqualTo("/cache")) | ||
| .willReturn(aResponse().withBody("{\"responses\":[{\"uuid\":\"f31f96db-8c36-4d44-94dc-ad2d1a1d84d9\"}]}"))); | ||
|
|
||
| PostCacheHandler handler = new PostCacheHandler(repository, cacheConfig, metricsRecorder, builder, currentDateProvider); |
Contributor
There was a problem hiding this comment.
You are using mixed approach in variables naming, below in this test val is used, so replace types with val or val with types.
|
|
||
| @Test | ||
| void testUUIDDuplication() { | ||
| CacheConfig cacheConfigLocal = new CacheConfig(cacheConfig.getPrefix(), cacheConfig.getExpirySec(), cacheConfig.getTimeoutMs(), |
Contributor
There was a problem hiding this comment.
You are using mixed approach in variables naming, below in this test val is used, so replace types with val or val with types.
TerentievEvgany
approved these changes
Oct 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added option to prevent uuid duplications
for now implemented only for aerospike