Ease of adding routes to Vert.x router#17
Closed
jordillachmrf wants to merge 11 commits into
Closed
Conversation
We would like to add some custom routes to the Vertx router, but its prototype bean scope results in a new instance per injection point, so there is no way to modify the one injected in PrebidVerticle. It would be handy if WebConfiguration could receive an optional Consumer<Router> that would allow us to add these new routes.
Contributor
|
Thanks for the PR. Regarding this one the same question arises: what is the motivation for this change? If it's just about defining an extension point then as I understand one way or another you will have to maintain the fork of the prebid-server with additional functionality implemented so it should not be a problem to alter routes definition with anything you want there. Another thing to consider is whether these extra endpoints belong to prebid-server (architecture-wise) and if yes maybe it is a good idea to add them to the open-source version. |
schernysh
pushed a commit
that referenced
this pull request
Nov 25, 2019
ishihanvcs
pushed a commit
to ishihanvcs/prebid-server-java
that referenced
this pull request
Apr 10, 2023
Metrics and app Approved-by: Mohammad Nurul Islam Shihan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We would like to add some custom routes to the Vertx router, but its prototype bean scope results in a new instance per injection point, so there is no way to modify the one injected in PrebidVerticle.
It would be handy if WebConfiguration could receive an optional Consumer that would allow us to add these new routes.
Sorry, could you just take into account changes related to e8e3563, if those changes are fine I would create a new clean PR