Test: bid adjustments matching strategy#3940
Merged
osulzhenko merged 4 commits intoMay 28, 2025
Merged
Conversation
Collaborator
Author
|
Corresponding issue prebid/prebid-server#4271 |
marki1an
changed the base branch from
master
to
bid-adjustments-rules-matching-strategy
…es-matching-strategy' into tests/bid-adjustments-matching-strategy
osulzhenko
requested changes
May 22, 2025
Collaborator
osulzhenko
left a comment
osulzhenko
left a comment
There was a problem hiding this comment.
What if:
adapterCode doesn't match at all?
dealId is the same, but the bidder is different?
we have both a generic rule like *|seat|* and a specific one like banner|seat|111?
Comment on lines
+13
to
+17
| Map<String, List<AdjustmentRule>> amx | ||
| @JsonProperty("ALIAS") | ||
| Map<String, List<AdjustmentRule>> aliasUpperCase | ||
| @JsonProperty("AlIaS") | ||
| Map<String, List<AdjustmentRule>> aliasCamelCase |
Collaborator
There was a problem hiding this comment.
nitpick. Pls group up aliases:
@JsonProperty('*')
Map<String, List<AdjustmentRule>> wildcardBidder
Map<String, List<AdjustmentRule>> generic
Map<String, List<AdjustmentRule>> alias
@JsonProperty("ALIAS")
Map<String, List<AdjustmentRule>> aliasUpperCase
@JsonProperty("AlIaS")
Map<String, List<AdjustmentRule>> aliasCamelCase
Map<String, List<AdjustmentRule>> amx
| bidAdjustmentFactor << [0.9, 1.1] | ||
| } | ||
|
|
||
| def "PBS should adjust bid price when bid adjustment bidder and bidder code different"() { |
Collaborator
There was a problem hiding this comment.
We definitely need to check for bidderCode. Same for the others
| assert bidderRequest.cur == [currency] | ||
| } | ||
|
|
||
| def "PBS should adjust bid price when bid adjustment bidder with different case strategy and bidder code different"() { |
Collaborator
There was a problem hiding this comment.
It looks like this test is similar to the previous one. Can we merge them?
osulzhenko
approved these changes
May 28, 2025
osulzhenko
merged commit a828c32
into
bid-adjustments-rules-matching-strategy
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check