Conversation
| return false | ||
| } | ||
|
|
||
| // Structs to handle parsed bidder info, so we aren't reparsing every request |
adapters/info.go
Outdated
| var allowedMediaTypes parsedSupports | ||
| if request.Site != nil { | ||
| if i.info.Capabilities.Site == nil { | ||
| if i.info.site.enabled == false { |
There was a problem hiding this comment.
fairly silly nitpick, but... if !i.info.site.enabled
| v.AddConfigPath(".") | ||
| v.AddConfigPath("/etc/config") | ||
|
|
||
| func SetupViper(v *viper.Viper, filename string) { |
There was a problem hiding this comment.
Little puzzled... what happened here?
Does this go away if you merge master into the branch? I'd've sworn we already merged these changes elsewhere.
There was a problem hiding this comment.
Ok, I am really puzzled as config/config.go was not part of the commit when I created it.
| glog.Fatalf("Failed to create the bidder params validator. %v", err) | ||
| } | ||
|
|
||
| bidderInfos := adapters.ParseBidderInfos("./static/bidder-info", openrtb_ext.BidderList()) |
There was a problem hiding this comment.
This should be safe, but... please do build & run this once in a docker container locally, just to make sure the files & paths still work.
There was a problem hiding this comment.
This is the exact same line as from below, just moved up so exchange.NewExchange has access to it. Is there something about moving it that might break something?
There was a problem hiding this comment.
ah, of course... no, you're fine then. Ignore me
|
Contributes to #555 |
* Sets a config file name so we can redirect to non-existent file for tests * Better handling of tests * fixes mismatched name * Enables the bidder decorator to enforce the bidder-info yamls * improves slightly a couple of if clauses
* Sets a config file name so we can redirect to non-existent file for tests * Better handling of tests * fixes mismatched name * Enables the bidder decorator to enforce the bidder-info yamls * improves slightly a couple of if clauses
* Sets a config file name so we can redirect to non-existent file for tests * Better handling of tests * fixes mismatched name * Enables the bidder decorator to enforce the bidder-info yamls * improves slightly a couple of if clauses
3 participants
This enforces the bidder capabilities listed in bidder-info.yaml. Server logging has been added to the redundant checks within the adapter code so we can verify they are not needed and remove them with a later PR. Note that this does not cover legacy adapters that have been wrapped with the legacy->openRTB adapter.