Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
muuki88
reviewed
Sep 5, 2023
| ucTagData.targetingMap = %%PATTERN:TARGETINGMAP%%; | ||
| ucTagData.hbPb = "%%PATTERN:hb_pb%%"; | ||
| // mobileResize needed for mobile GAM only | ||
| ucTagData.mobileResize = "hb_size:%%PATTERN:hb_size_BIDDERCODE%%"; |
Contributor
There was a problem hiding this comment.
I couldn't find any reference in the either prebid.js, prebid universal creative, prebid adnroid sdk or prebid server java.
Where is this going to be used and for what exactly @bretg ?
Contributor
Author
|
good thing you pushed back @muuki88 - turns out there's a reason it's not in the Send-Top-Bid creative -- the TARGETINGMAP covers the use case. So changing this PR to explain the existence of mobileResize in the Send-All-Bids creative. |
bretg
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this is still needed for the mobile PUC scenario. It was there for the Send-All-Bidders example, but missing for Sent-Top-Bid.