Skip to content

Smrtconnect Bid Adapter: initial release doc#5198

Merged
bretg merged 2 commits intoprebid:masterfrom
psmrt:smrtconnect_adapter
Apr 3, 2024
Merged

Smrtconnect Bid Adapter: initial release doc#5198
bretg merged 2 commits intoprebid:masterfrom
psmrt:smrtconnect_adapter

Conversation

@psmrt
Copy link
Copy Markdown
Contributor

@psmrt psmrt commented Mar 13, 2024 •
edited
Loading

  • feat: add doc for smrtconnect md

🏷 Type of documentation

  • new bid adapter

📋 Checklist

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 13, 2024 •
edited
Loading

✅ Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 0bb836c
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/660d5a2e621aa70008a25a8d
😎 Deploy Preview https://deploy-preview-5198--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@psmrt psmrt force-pushed the smrtconnect_adapter branch 2 times, most recently from 2d8f47a to 4490156 Compare March 13, 2024 14:31
bretg
bretg reviewed Mar 25, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok, but there are a number of missing metadata fields. Please supply the ones missing from the list at https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html#user-documentation

e.g. floors_supported, fpd_supported, ortb_blocking_supported, privacy_sandbox. gpp_sids

@psmrt psmrt force-pushed the smrtconnect_adapter branch from 4490156 to 9685c9f Compare March 27, 2024 12:52
@psmrt
Copy link
Copy Markdown
Contributor Author

psmrt commented Mar 27, 2024

This looks ok, but there are a number of missing metadata fields. Please supply the ones missing from the list at https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html#user-documentation

e.g. floors_supported, fpd_supported, ortb_blocking_supported, privacy_sandbox. gpp_sids

Thanks for review. I have updated PR with missing fields.

@psmrt psmrt requested a review from bretg April 3, 2024 07:21
@bretg bretg added LGTM and removed needs work labels Apr 3, 2024
@bretg bretg merged commit f400ffb into prebid:master Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bretg bretg bretg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

LGTM

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@psmrt @bretg