Skip to content

Fix bidder-data CSV generation Issue with multiformat_supported column#5872

Merged
muuki88 merged 1 commit intoprebid:masterfrom
onfocusio:chore/fix-data-csv-generator
Feb 19, 2025
Merged

Fix bidder-data CSV generation Issue with multiformat_supported column#5872
muuki88 merged 1 commit intoprebid:masterfrom
onfocusio:chore/fix-data-csv-generator

Conversation

@osazos
Copy link
Copy Markdown
Contributor

@osazos osazos commented Feb 12, 2025

The current implementation of the CSV generation layout in Jekyll can result in a broken CSV structure when the multiformat_supported column contains commas. This is because commas within the field are interpreted as delimiters, leading to incorrect parsing of the CSV file.

Proposed Solution:

Wrap the content of the multiformat_supported column in double quotes to ensure that any commas within the field are treated as part of the field value.

Ask maintainers to fix their .md files to ensure data integrity:

Update of the relevant part of the Jekyll layout:

{% if page.multiformat_supported %}"{{ page.multiformat_supported | replace: '"', '""' }}"{% else %}check with bidder{% endif %}

Closes #5871

@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 12, 2025

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 6a7fcd9
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/67ac7254fa475000088aa07b
😎 Deploy Preview https://deploy-preview-5872--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ChrisHuie ChrisHuie requested a review from muuki88 February 18, 2025 15:36
@ChrisHuie ChrisHuie removed the request for review from muuki88 February 18, 2025 15:37
@muuki88 muuki88 merged commit 2eca481 into prebid:master Feb 19, 2025
muuki88 added a commit that referenced this pull request Feb 19, 2025
muuki88 added a commit that referenced this pull request Feb 19, 2025
@osazos osazos deleted the chore/fix-data-csv-generator branch October 30, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bidder-data CSV Generation Issue with multiformat_supported Column

2 participants