Skip to content

Conversation

@robin-crazygames
Copy link
Contributor

The video in the Bid Params is optional for video ad units and not required.

Reasons:

  const videoInMediaType = deepAccess(bidRequest, 'mediaTypes.video') || {};
  const videoInParams = deepAccess(bidRequest, 'params.video') || {};
  const videoCombinedObj = Object.assign({}, videoInParams, videoInMediaType);

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

  • Related pull requests in prebid.js or server are linked -> Paste link in this list or reference it on the PR itself
  • For new adapters check submitting your adapter docs

The `video` in the Bid Params is optional for video ad units and not required.

Reasons:

* The example further down in the docs "Example of Instream Video Ad-unit" doesn't contain a `video` in the bids params.
* The actual code in the bid adapter can deal with missing video. See https://github.com/prebid/Prebid.js/blob/fb3f801f4099798b1dd6e1aeb9e3dfc6e41982c9/modules/medianetBidAdapter.js#L215 :

```javascript
  const videoInMediaType = deepAccess(bidRequest, 'mediaTypes.video') || {};
  const videoInParams = deepAccess(bidRequest, 'params.video') || {};
  const videoCombinedObj = Object.assign({}, videoInParams, videoInMediaType);
```
@netlify
Copy link

netlify bot commented Aug 29, 2025

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit e0b06da
🔍 Latest deploy log https://app.netlify.com/projects/prebid-docs-preview/deploys/68b15aedfded6500086d0adc
😎 Deploy Preview https://deploy-preview-6232--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ChrisHuie ChrisHuie added the LGTM label Aug 29, 2025
@ChrisHuie ChrisHuie merged commit 24737f5 into prebid:master Aug 29, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants