Shortened filename in cache#78
Conversation
by appending first 6 chars of md5-hashed download url to filename
|
I'm thinking, while we're at it, it could be useful to document in the readme that |
|
Will this mean a new major version? |
|
AFAICT the cached files are an implementation detail and not part of the user visible API, right? If that's the case then there should be no need for a new major version. |
This is indeed a good idea. I personally don't like software that clutters my disk without the knowledge of the user if the path is not the systems default temp folder.
IMHO there is no need for a major this time, because no public API and it is not yet documented. I like this solution btw :) |
|
Thanks for merging :) |
This implements Option 2 from #77.
The test file's name changes from
to
This is mostly for continuing the discussion from #77 -- let me know if you'd rather have what I outlined in Option 1 or something else entirely.
It might also make sense to actually verify that the filename is shorter than 140 chars and truncate part of it if that's the case.