Conversation
This was referenced Jan 28, 2025
davidscn
reviewed
Jan 28, 2025
davidscn
reviewed
Feb 5, 2025
Member
davidscn
left a comment
davidscn
left a comment
There was a problem hiding this comment.
Looks good. What happens when I disable the output mesh writing/accuracy metrics and use the plotting scripts? Will it explode? As it is looking for the l2error.
Member
Author
|
Currently, only memory and runtime plots should be generated. The rest would crash. Maybe it would be an idea to change the plotting scripts to only plot the columns they find. I'll open a separate PR |
davidscn
reviewed
Feb 6, 2025
Member
davidscn
left a comment
davidscn
left a comment
There was a problem hiding this comment.
Can you document this change in the main ASTE docs?
fsimonis
force-pushed
the
optional-output-2
branch
from
5540a1e to
a62574c
Compare
Member
Author
|
Rebased and cleaned up the PR. I'll merge after the CI passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes of this PR
Based on #210
This PR makes the
--outputargument ofprecice-aste-runof solver B optional, which disables writing the mapped data.This can be useful in situations where only the runtime is measured and the result isn't needed.
The mapping tester also adds
general>writeMappedto the setup which controls this for the entire case.Author's checklist
pre-commithook and usedpre-commit run --allto apply all available hooks.docs/README.md../changelog-entries/(create if necessary).precice/tutorials/aste-turbine.