Update adapter.py conform preCICE v1.4.1 and Code_Aster v14.4 #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MakisH
requested changes
Dec 18, 2019
Member
MakisH
left a comment
MakisH
left a comment
There was a problem hiding this comment.
Overall, it looks good. Please check the formatting (the tab length seems to have increased) and a few minor comments I added here.
A possible next step would then be to try with the latest preCICE release and/or directly with preCICE develop.
micheltakken
changed the title
Add correct astk file
Update astk.solid file to generate the correct solid.export file
1. change the variable name in adapter.py, e.g., from timestep to time_window 2. chaged the base-path according to tmy computer. 3. add the preciceDict to the openFoam solber, 4. update the precide-config.xml file according to the new setting
Add Code_Aster output functionality for the flow-over-plate tutorial
Add tutorial for CHT coupling with OpenFOAM and Code-Aster: flow-over-plate
…code_aster-adapter into chenghui62000-tutorial-addition
MakisH
reviewed
Mar 2, 2020
MakisH
reviewed
Mar 2, 2020
MakisH
reviewed
Mar 2, 2020
MakisH
reviewed
Mar 2, 2020
MakisH
reviewed
Mar 2, 2020
MakisH
reviewed
Mar 2, 2020
MakisH
reviewed
Mar 2, 2020
Upgrade Code-Aster Adapter for preCICE 2.0
Co-Authored-By: Gerasimos Chourdakis <makishourdakis@gmail.com>
…update Allclean. Remove hard-coded path.
MakisH
reviewed
Mar 20, 2020
MakisH
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version of the adapter supports preCICE v1.4.1 and Code_Aster v14.4 on an Ubuntu 18.04 system