Skip to content

Refactor DomainDecomposer class and add new functionality to decompose the macro-scale coordinates#243

Merged
IshaanDesai merged 21 commits intodevelopfrom
custom-domain-decomposition
Apr 15, 2026
Merged

Refactor DomainDecomposer class and add new functionality to decompose the macro-scale coordinates#243
IshaanDesai merged 21 commits intodevelopfrom
custom-domain-decomposition

Conversation

@IshaanDesai
Copy link
Copy Markdown
Member

@IshaanDesai IshaanDesai commented Apr 8, 2026

Apart from general refactoring of the DomainDecomposer class, this PR also adds the following:

  • A new non-uniform domain decomposition variant based on geometric progression is intended to address asymmetrical loaded scenarios such as the two-scale heat conduction.
  • There is a corresponding new optional configuration parameter, decomposition_type, which can be either uniform or nonuniform.
  • Additionally, a new optional configuration parameter minimum_access_region_size can be set. This sets the minimum axis width of the access region, which is essential when a non-uniform domain decomposition is required.
  • Remove the Exception when a rank does not receive macro-scale vertices via direct access. This can happen if the access region is too small or too obscure, leaving no macro-scale vertices within it.
  • Add an Exception when a rank has no macro-scale vertices, but lazy initialization is used, because then the rank cannot collect initial data to calculate the initial adaptivity on.

Checklist:

  • I added a summary of the changes (compared to the last release) in the CHANGELOG.md.
  • If necessary, I made changes to the documentation and/or added new content.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

@IshaanDesai IshaanDesai added the new-feature Adding a new feature label Apr 8, 2026
@IshaanDesai IshaanDesai self-assigned this Apr 8, 2026
@IshaanDesai IshaanDesai changed the title Add a non-uniform domain decomposition variant based on geometric progression Refactor DomainDecomposer class and add new functionality to decompose the macro-scale coordinates Apr 12, 2026
@IshaanDesai IshaanDesai added the breaking change A change will break backwards compatibilty label Apr 13, 2026
@IshaanDesai IshaanDesai merged commit b680b89 into develop Apr 15, 2026
10 checks passed
@IshaanDesai IshaanDesai deleted the custom-domain-decomposition branch April 15, 2026 08:55
@IshaanDesai IshaanDesai mentioned this pull request Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change A change will break backwards compatibilty new-feature Adding a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant