Refactor DomainDecomposer class and add new functionality to decompose the macro-scale coordinates#243
Merged
IshaanDesai merged 21 commits intodevelopfrom Apr 15, 2026
Merged
Conversation
… the non-uniform decomposition
…ialization is done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apart from general refactoring of the
DomainDecomposerclass, this PR also adds the following:decomposition_type, which can be eitheruniformornonuniform.minimum_access_region_sizecan be set. This sets the minimum axis width of the access region, which is essential when a non-uniform domain decomposition is required.Exceptionwhen a rank does not receive macro-scale vertices via direct access. This can happen if the access region is too small or too obscure, leaving no macro-scale vertices within it.Exceptionwhen a rank has no macro-scale vertices, but lazy initialization is used, because then the rank cannot collect initial data to calculate the initial adaptivity on.Checklist:
CHANGELOG.md.