Skip to content

Fix comparison of zero values of type float32 and float64 in simulation deactivation#244

Merged
IshaanDesai merged 2 commits intodevelopfrom
fix-zero-initial-data-lazy-init
Apr 10, 2026
Merged

Fix comparison of zero values of type float32 and float64 in simulation deactivation#244
IshaanDesai merged 2 commits intodevelopfrom
fix-zero-initial-data-lazy-init

Conversation

@IshaanDesai
Copy link
Copy Markdown
Member

@IshaanDesai IshaanDesai commented Apr 10, 2026

If the adaptivity data is zero and the coarsening tolerance is set to sys.float.min, the if condition in deactivation can lead to a false negative.

Checklist:

  • I added a summary of the changes (compared to the last release) in the CHANGELOG.md.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

@IshaanDesai IshaanDesai merged commit 4526b6e into develop Apr 10, 2026
10 checks passed
@IshaanDesai IshaanDesai deleted the fix-zero-initial-data-lazy-init branch April 10, 2026 12:54
@IshaanDesai IshaanDesai mentioned this pull request Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant