fix: standardise local asset URLs to use Liquid filter in head includes#788
Open
Parth-Garg2629 wants to merge 4 commits intoprecice:masterfrom
Open
fix: standardise local asset URLs to use Liquid filter in head includes#788Parth-Garg2629 wants to merge 4 commits intoprecice:masterfrom
Parth-Garg2629 wants to merge 4 commits intoprecice:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR standardizes local asset URL references in Jekyll head includes by wrapping bare paths in Liquid output syntax {{ "..." }}. While functionally this produces the same output as bare paths (since no filters are applied), it creates consistency with the existing pattern used for some assets like css/syntax.css. The site's flat permalink structure (all pages served from root level) means relative paths work correctly without requiring baseurl handling.
Changes:
- Wrapped 11 local asset paths in
_includes/head.htmlin Liquid output tags (favicons, CSS files, and JavaScript files) - Wrapped 18 local asset paths in
_includes/head_print.htmlin Liquid output tags (favicons, CSS files, and JavaScript files)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
_includes/head.html |
Standardized 11 local asset references (images, CSS, JS) to use {{ "path" }} syntax instead of bare paths |
_includes/head_print.html |
Standardized 18 local asset references (images, CSS, JS) to use {{ "path" }} syntax instead of bare paths |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local asset references in _includes/head.html and _includes/head_print.html were using bare paths (e.g.
href="css/main.css") inconsistently alongside already-correct Liquid-filtered paths (e.g.href="{{ "css/syntax.css" }}").Bare paths silently break when Jekyll is deployed with a non-root
baseurl. Wrapping all local asset paths in{{ "..." }}ensures correct URL resolution in all deployment scenarios.Changed files:
No functional change for root deployments (like precice.org).
Closes #787