Conversation
|
Result is not as nice as hoped for in #64 (comment), but still a step into the right direction. I will now add the suggested changes from #64 (comment) |
|
If I try to replace |
|
I have the impression that |
|
It does not work completely. When I try to install the bindings using the standard installation options of Spack (by hand) via When adaptiing the the shared libraries are copied. However, it ALSO copies the libraries for the test. I am not sure if that should be like that. Note: I have not tested if the resulting python module works. |
IshaanDesai
left a comment
IshaanDesai
left a comment
There was a problem hiding this comment.
Current state works well with the fenics-adapter and a prototype tutorial case.
IshaanDesai
left a comment
IshaanDesai
left a comment
There was a problem hiding this comment.
Installation works. Checked with the fenics-adapter and a tutorial case.
I did not check the Spack package usage.
|
I tried to add some print statements for debugging in |
This reverts commit abf1396.
Reverted abf1396 via 477526a. Now everything works, but we - again - depend on |
|
f82d5e4 allows us to get rid of the
However, there is one downside:
I think this is still not a perfect solution, but as far as I am concerned it looks to me at least like an improvement. Any opinions? |
BenjaminRodenberg
left a comment
BenjaminRodenberg
left a comment
There was a problem hiding this comment.
To summarize the current state:
- custom commands only override
finalize_options. Notinitialize_options. my_buildis not used anymore.my_installinherits fromsetuptools.commands.install, notdistutils.commands.install.installoption--single-version-externally-managedis available. #64
| from setuptools import setup | ||
| from setuptools import Command | ||
| from setuptools.command.test import test | ||
| from setuptools.command.install import install |
There was a problem hiding this comment.
Just realized that this version now uses setuptools.command.install and not distutils.command.install. This makes --single-version-externally-managed is available (python3 setup.py install --help). See #64.
There was a problem hiding this comment.
Sounds good. I will check if it works with the standard installation procedure of Spack now.
|
I was able to install the bindings from this PR (branch # Copyright 2013-2019 Lawrence Livermore National Security, LLC and other
# Spack Project Developers. See the top-level COPYRIGHT file for details.
#
# SPDX-License-Identifier: (Apache-2.0 OR MIT)
from spack import *
class PyPyprecice(PythonPackage):
"""
This package provides python language bindings for the
C++ library preCICE.
"""
homepage = "https://www.precice.org"
git = "https://github.com/precice/python-bindings.git"
url = "https://github.com/precice/python-bindings/archive/v2.0.0.1.tar.gz"
maintainers = ["ajaust", "BenjaminRueth"]
# Always prefer final version of release candidate
version("develop", branch="i_64")
version("2.1.1.1", sha256="972f574549344b6155a8dd415b6d82512e00fa154ca25ae7e36b68d4d2ed2cf4")
version("2.1.0.1", sha256="ac5cb7412c6b96b08a04fa86ea38e52d91ea739a3bd1c209baa93a8275e4e01a")
version("2.0.2.1", sha256="c6fca26332316de041f559aecbf23122a85d6348baa5d3252be4ddcd5e94c09a")
version("2.0.1.1", sha256="2791e7c7e2b04bc918f09f3dfca2d3371e6f8cbb7e57c82bd674703f4fa00be7")
version("2.0.0.2", sha256="5f055d809d65ec2e81f4d001812a250f50418de59990b47d6bcb12b88da5f5d7")
version("2.0.0.1", sha256="96eafdf421ec61ad6fcf0ab1d3cf210831a815272984c470b2aea57d4d0c9e0e")
# Import module as a test
import_modules = ["precice"]
# patch("deactivate-version-check-via-pip.patch")
patch("remove-packaging-and-pip.patch")
variant("mpi", default=True, description="Enables MPI support")
depends_on("mpi", when="+mpi")
depends_on("precice@2.1.1")
depends_on("precice@2.1.1", when="@2.1.1.1:2.1.1.99")
depends_on("precice@2.1.0", when="@2.1.0.1:2.1.0.99")
depends_on("precice@2.0.2", when="@2.0.2.1:2.0.2.99")
depends_on("precice@2.0.1", when="@2.0.1.1:2.0.1.99")
depends_on("precice@2.0.0", when="@2.0.0.1:2.0.0.99")
depends_on("python@3:", type=("build", "run"))
depends_on("py-setuptools", type="build")
depends_on("py-wheel", type="build")
depends_on("py-numpy", type=("build", "run"))
depends_on("py-mpi4py", type=("build", "run"), when="+mpi")
depends_on("py-cython@0.29:", type=("build"))
phases = ['build_ext', 'install']
def build_ext_args(self, spec, prefix):
return [
"--include-dirs=" + spec["precice"].headers.directories[0],
"--library-dirs=" + spec["precice"].libs.directories[0]
]
#def install(self, spec, prefix):
#self.setup_py("install", "--prefix={0}".format(prefix))I needed a new patch: This would need some polishing, but in general it seems to be fine. I tried to use |
ajaust
left a comment
ajaust
left a comment
There was a problem hiding this comment.
The changes look good and changes to be made to the Spack package are mentioned above, see #65 (comment).
3 participants
closes #64