Skip to content

Check that input is array_like, if required#80

Merged
BenjaminRodenberg merged 8 commits intodevelopfrom
i_79
Jan 18, 2021
Merged

Check that input is array_like, if required#80
BenjaminRodenberg merged 8 commits intodevelopfrom
i_79

Conversation

@BenjaminRodenberg
Copy link
Contributor

Related to #79.

@BenjaminRodenberg
Copy link
Contributor Author

@MakisH @IshaanDesai Note: I will implement check_array_like for all functions that actually accept a array_like, if you agree with the general approach. Just don't want to roll this out to the whole bindings just to revert/change it. Let's prototype this first at the example of read_block_scalar_data and write_block_scalar_data

@BenjaminRodenberg
Copy link
Contributor Author

Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error message is very helpful and much better than before! 👍

I have not tried running the code. The target branch looks correct. Maybe squash your two commits.

@BenjaminRodenberg
Copy link
Contributor Author

Now all API functions are fixed in the same fashion. Waiting for the review of @IshaanDesai. I will squash everything into one single commit 👍

@BenjaminRodenberg BenjaminRodenberg merged commit e1ee68a into develop Jan 18, 2021
@BenjaminRodenberg BenjaminRodenberg deleted the i_79 branch January 18, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants