Check code formatting with autopep8, fix formatting for codebase#82
Check code formatting with autopep8, fix formatting for codebase#82BenjaminRodenberg merged 24 commits intodevelopfrom
Conversation
Use code and examples from https://github.com/peter-evans/autopep8
|
@IshaanDesai For review: Please take special care about b6e013a, since I touched the tests here. Hopefully did not break anything. |
BenjaminRodenberg
left a comment
BenjaminRodenberg
left a comment
There was a problem hiding this comment.
Ready for review. Already had a very close look at test/test_bindings_module.py. I'm quite hopeful that I did not break the tests.
| help="Name of the xml config file.", type=str) | ||
| parser.add_argument("participantName", help="Name of the solver.", type=str) | ||
| parser.add_argument("meshName", help="Name of the mesh.", type=str) | ||
|
|
There was a problem hiding this comment.
| args = None |
| interface = precice.Interface(participant_name, configuration_file_name, solver_process_index, solver_process_size) | ||
| interface = precice.Interface(participant_name, configuration_file_name, | ||
| solver_process_index, solver_process_size) | ||
|
|
There was a problem hiding this comment.
| read_data_name, write_data_name = None, None |
This line can go even further below but I was not able to add a suggestion where there was no code change in the review.
IshaanDesai
left a comment
IshaanDesai
left a comment
There was a problem hiding this comment.
In setup.py function names like my_build_ext and my_install prompt a suggestion Class names should use CamelCase convention. I am not sure if this is relevant and important.
Technically yes. However, I think this is a corner case, since also setuptools diverges from this convention: So let's keep it as it is. Thanks for the review! I will merge now. |
2 participants
No description provided.