Conversation
3901619 to
5fbf26e
Compare
MakisH
left a comment
There was a problem hiding this comment.
Thanks for the amazing work! I briefly looked at the code, I did not see anything suspicious, but the diff is of course very large.
While trying to build, I got some warnings for unused variables:
[ 25%] Building CXX object CMakeFiles/FluidSolver.dir/src/FluidSolver.cpp.o
/home/makish/github/tutorials/elastic-tube-1d/fluid-cpp/src/FluidSolver.cpp: In function ‘int main(int, char**)’:
/home/makish/github/tutorials/elastic-tube-1d/fluid-cpp/src/FluidSolver.cpp:32:16: warning: unused variable ‘tau’ [-Wunused-variable]
32 | const double tau = atof(argv[3]);
| ^~~
/home/makish/github/tutorials/elastic-tube-1d/fluid-cpp/src/FluidSolver.cpp:54:16: warning: unused variable ‘E’ [-Wunused-variable]
54 | const double E = 10000; // elasticity module
| ^
Other than that, it runs, the results look good (very similar with Python). I also tried all four combinations, and I get similar results.
|
@MakisH could you reimplement the command line arguments? |
|
I am currently going the other way around and removing them from the C++ version, as we have not really tested that this works with more values. We could, in the future, add them again. |
MakisH
left a comment
There was a problem hiding this comment.
I removed the additional command-line arguments from the C++ version, as we have not really tested if arbitrary values work and I don't want to open another box at this point. It is anyway not important at all.
I also removed the Elasticity module from both the C++ and Python solvers, it was not needed there.
Ready to merge! 🎉
This PR:
Closes #194
Closes #193
Closes #195