Skip to content

Add a check for the image sizes#203

Merged
davidscn merged 5 commits intoprecice:developfrom
davidscn:check-size
Apr 14, 2021
Merged

Add a check for the image sizes#203
davidscn merged 5 commits intoprecice:developfrom
davidscn:check-size

Conversation

@davidscn
Copy link
Copy Markdown
Member

@davidscn davidscn commented Apr 14, 2021

Related to precice/precice.github.io#48

The check works, but we have currently some files above the limit of 250 kb. So we either need to live with the failing check, decrease the corresponding image size further or increase the limit.

@davidscn davidscn self-assigned this Apr 14, 2021
@MakisH
Copy link
Copy Markdown
Member

MakisH commented Apr 14, 2021

Where can I see the list of files remaining? Yesterday I resized most of them, I only kept the VM screenshot because I am going to update it very soon.

@davidscn
Copy link
Copy Markdown
Member Author

I reduced the verbosity of passing images in order to make it more obvious.
You can either click on Details in the GH CI or run ./tools/check-size.sh in the tutorial repository.

@MakisH
Copy link
Copy Markdown
Member

MakisH commented Apr 14, 2021

I resized two PNG images that were left. Could you please exclude .gif files or set a different limit there? Something around 1.5MB-2MB should be enough.

@davidscn
Copy link
Copy Markdown
Member Author

Increased it to 2000 kb. The GH CI supports now also coloring.

@davidscn davidscn requested a review from MakisH April 14, 2021 13:33
@MakisH
Copy link
Copy Markdown
Member

MakisH commented Apr 14, 2021

The partitioned heat conduction GIF I already tried to reduce in size but I could not. I guess it makes sense to increase the threshold then (e.g. 3MB). We have almost no GIFs anyway.

@davidscn
Copy link
Copy Markdown
Member Author

Then let me increase it to 2.2. so that the test passes. If this becomes problematic in the future we can still increase the limit.

@davidscn davidscn merged commit 6feb39c into precice:develop Apr 14, 2021
@davidscn davidscn deleted the check-size branch April 14, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants