Split the system tests log file into stages#801
Open
PranjalManhgaye wants to merge 8 commits into
Open
Conversation
Write build, solver, and fieldcompare output incrementally to system-tests-stdout.log and system-tests-stderr.log, and add phase logs (system-tests-build.log, -solver.log, -fieldcompare.log) so failures can be debugged before a test finishes. Extend CI artifact globs for the new log files. Fixes the log-file part of precice#790.
Drop INFO prefix on routine log lines, put test index at the start of start/finish messages, and add blank lines between tests for easier scanning in CI and local runs. Addresses the console formatting part of precice#790.
Collaborator
Author
|
passed (17/17), but the console output still looks like the old style, is this workflow expected to run with |
Member
|
@PranjalManhgaye I am not sure if this is currently documented (please check), but the By the way, I think this PR can use a more descriptive title. How about "Split the system tests log file into stages"? Do not forget to update the documentation and the hints in the workflow files (look for the original file name). |
PranjalManhgaye
changed the title
Document combined and per-stage system test logs in README and job summary hints, and clarify workflow artifact step names to reflect staged log files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #790.
Right now,
system-tests-stdout.logandsystem-tests-stderr.logonly appear after a test finishes, which makes it hard to inspect failures during long Docker builds or solver runs.This PR changes the logging so output is written to disk while the test is running. The existing combined logs are still kept, but there are now also separate phase logs:
system-tests-build.logsystem-tests-solver.logsystem-tests-fieldcompare.logScope: 4 files only (~350 LOC). No tutorial or reference-result changes.
Largest change: streaming Docker output in
Systemtest.py(replaces communicate() buffering).I also cleaned up the console output a bit:
[n/m]progress prefixINFO:removed)PASS/FAILmarkers on TTYThe PR is split into 4 commits so the logging change can be reviewed separately from the console formatting cleanup.
Checklist
changelog-entries/<PRnumber>.md.fluid-openfoamfolder for existing tutorial)? Add it to the respectiveREADME.md.Resources