Prune Docker networks before and after running each system test#820
Merged
Conversation
MakisH
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Trying to run several tests (each one asking Docker Compose to create a custom network), we now hit a limit on how many custom networks one can create on a given system (see this failing system tests job). While we were already calling
docker network prunein the CI workflows, we now hit the limit within one run.This could be seen in the
system-tests-stderr.logas:This PR implements a new function in the
Systemtest.pyto prune networks before (from previous runs) and after (from this run) running the tests.Checklist
changelog-entries/<PRnumber>.md.