Parallelize PR system tests via GitHub Actions matrix.#829
Open
PranjalManhgaye wants to merge 2 commits into
Open
Parallelize PR system tests via GitHub Actions matrix.#829PranjalManhgaye wants to merge 2 commits into
PranjalManhgaye wants to merge 2 commits into
Conversation
Add release_test_shard_1/2 covering the same cases as release_test, and run them as separate matrix jobs for clearer logs and cheaper reruns.
Collaborator
Author
|
@MakisH follow-ups (i think later, not this PR) :
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR splits PR system tests into two GitHub Actions matrix jobs (
release_test_shard_1andrelease_test_shard_2). Together they cover the same 48 cases asrelease_test; I leftrelease_testitself unchanged so manual runs and other workflows still work as before, I setfail-fast: falseso if one shard fails, the other keeps running => that makes failures easier to read and cheaper to retry.Why
Right now, when one test fails you often have to re-run the whole suite and dig through one huge log. With two shards, you get smaller logs per job and can re-run only the failed matrix job.
If we have two
precice-tests-vmrunners, the shards can run in parallel. On a single runner they may still queue, but we still get clearer CI output => which matches what we discussed for this issue.Test plan
python3 validate_release_test_shards.py=>48 cases = 24 + 24system-tests-devwith--rundiron the precice-data partition (pass)trigger-system-testsso we can verify onprecice-tests-vm(I don’t have access to trigger that from my side ig)Notes
release_test; we can extend the matrix there in a follow-up if you want.close #789