Skip to content

Comments

Small changes to build on Cygwin under MSWindows10#172

Merged
preda merged 3 commits intopreda:masterfrom
wedgingt:master
Jun 29, 2020
Merged

Small changes to build on Cygwin under MSWindows10#172
preda merged 3 commits intopreda:masterfrom
wedgingt:master

Conversation

@wedgingt
Copy link
Contributor

Queue.h - an #fidef CYGWIN to use sleep() instead of usleep().
.gitignore - add .d and a couple of files created during make.
AMD3.0 - a soft link to a common place for OpenCL from AMD.

wedgingt added 2 commits June 23, 2020 21:29
Queue.h: usleep() is not available on Cygwin; use sleep(1) for now.
AMD3.0: soft link to the usual location for OpenCL on MSWindows10,
supporting:

  make LIBPATH=-LAMD3.0/lib/x86_64
@preda
Copy link
Owner

preda commented Jun 28, 2020

Looks good with one observation: could you please drop the symbolic link -- given that it's useful only in a very particular case, it would be unsigtly for the other users.

@wedgingt
Copy link
Contributor Author

I included the soft link to make it easier for users to build with the AMD SDK and easier to describe how to do that.
I suspect most people won't even notice that the soft link is there without seeing it documented.
But if you really don't want it included, I marked this pull request as editable by the maintainers from the start.
Otherwise, I think I'd have to close/retract this pull request, drop the soft link, and create a new pull request.
Unless there's a way to edit this pull request, but I don't see one.

I would prefer to add the location in Makefile, rather than a link, because it's relevant only to a subset of users.
@preda preda merged commit e5a8f2c into preda:master Jun 29, 2020
@preda
Copy link
Owner

preda commented Jun 29, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants