Merged
Conversation
Contributor
magdyksaleh
commented
Sep 9, 2024
magdyksaleh
commented
- Remove indexing into input ids which is no longer needed
- Clean up protos
added 7 commits
August 27, 2024 18:32
magdyksaleh
commented
Sep 9, 2024
router/src/infer.rs
Outdated
| entity.word = input[entity.start..entity.end].to_string(); | ||
| entity.word = input[entity.start..entity.end] | ||
| .to_string() | ||
| .to_ascii_lowercase(); |
Contributor
Author
There was a problem hiding this comment.
Needed to exactly match HF output
Contributor
There was a problem hiding this comment.
Can you add this comment to the code here to explain the lowercasing?
tgaddair
approved these changes
Sep 9, 2024
magdyksaleh
added a commit
that referenced
this pull request
Sep 10, 2024
This reverts commit 19301c7.
|
@tgaddair @magdyksaleh Hi guys, NER and Sequence classification are fantastic features. Do you have a plan to release them? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.