Fix PREDIBASE_API_TOKEN env var being thrown away#654
Merged
seph-barker merged 1 commit intomainfrom Oct 22, 2024
Merged
Conversation
seph-barker
commented
Oct 22, 2024
| @@ -621,6 +611,13 @@ fn shard_manager( | |||
| // Copy current process env | |||
| let mut envs: Vec<(OsString, OsString)> = env::vars_os().collect(); | |||
Contributor
Author
There was a problem hiding this comment.
This line was introduced in #621 , which means that the value of envs is overwritten and no longer contains the value of PREDIBASE_API_TOKEN.
magdyksaleh
approved these changes
Oct 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced in #621. The Lorax launcher sets the environment variable PREDIBASE_API_TOKEN from the CLI flag --predibase-api-token. Unfortunately that PR overwrites the env var struct after the PREDIBASE_API_TOKEN has been set. :-(
Two deployments use this argument, 4421 and 4781. The latter uses an image that was build yesterday and so includes this bug, we will need to udpate it once this PR merges. (4421 is using an image that was built before this bug).