Remove GRPC, replace with SSE and Proto over HTTP API#56
Merged
jkebinger merged 22 commits intorelease-branch-v037from Apr 12, 2023
Merged
Remove GRPC, replace with SSE and Proto over HTTP API#56jkebinger merged 22 commits intorelease-branch-v037from
jkebinger merged 22 commits intorelease-branch-v037from
Conversation
jdwyah
reviewed
Apr 6, 2023
| connectivityTester = | ||
| new ConnectivityTester(() -> greetingServiceFutureStub(), httpClient, options); | ||
| connectivityTester.testHttps(); | ||
| grpcAvailable.set(options.isGrpcEnabled() && connectivityTester.testGrpc()); |
Contributor
There was a problem hiding this comment.
will this block until grpc is 👍 👎 ?
I think it's important that we get the config unlocked asap, by whatever means are working.
So if the CDN is working, great, unlock the configstore. This testGrpc should block the grpc strategies, but not the others.
Contributor
Author
There was a problem hiding this comment.
no this is a one shot test.
Add a fallback to fetch configs via API
This resulted in removing the unused RateLimitClient and upsert from the ConfigClient interface
jkebinger
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the client to check that prefab can be reached over http
and/or grpc. If grpc does not work then attempts to use grpc are disabled.Adds a http api client for logger stats
adds SSE for streaming updates
removes GRPC code entirely