feat: Add support for state-secrets repo#466
Open
juanjosevazquezgil wants to merge 6 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds initial wiring to support pushing ExternalSecret CRs to a dedicated state repository (intended to be state-secrets) during the firestartr-bootstrap push phase.
Changes:
- Replaces the CR push provider configuration from
terraformtosecretsin the bootstrap YAML types. - Updates bootstrap file pushing logic to filter
/resources/firestartr-crs/infraand push onlyExternalSecret.*CRs to the configured secrets repo.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| firestartr-bootstrap/types.go | Changes the pushFiles.crs.providers schema to use secrets instead of terraform. |
| firestartr-bootstrap/resources.go | Pushes only ExternalSecret.* CRs from the infra CR directory to the new secrets repo target. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #444