wip / feat: arithmetic expressions #134
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prsabahrami
reviewed
Sep 18, 2024
| evaluate_word_parts_inner(parts, false, state, stdin, stderr) | ||
| } | ||
|
|
||
| fn evaluate_arithmetic_expression(expr: ArithmeticExpr, state: &ShellState) -> Result<i64, String> { |
Contributor
There was a problem hiding this comment.
I don't think this considers precedence?
Contributor
|
This gets somewhat complicated. I have taken this down another path and started implementing that. We also should use Pratt Parsing in Pest to handle op precedence. I have created another WIP PR #147. I'll try to add some comments to make it easier to read. Overall, it is doable, but take a look at #147 and let me know what you think! I'll try to finish this by tomorrow and see if it works. I think the way I have implemented the other one makes it much easier to handle handle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to implement support for expressions such as
$((1 + 5)). Didn't really make it work all the way though.