feat Add parsing of arithmetics

[prsabahrami]

#134 (comment)

[codecov]

Codecov Report

Attention: Patch coverage is 35.88342% with 352 lines in your changes missing coverage. Please review.

Project coverage is 58.06%. Comparing base (144a8de) to head (49987a7).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/deno_task_shell/src/shell/types.rs	26.10%	201 Missing ⚠️
crates/deno_task_shell/src/shell/execute.rs	42.55%	81 Missing ⚠️
crates/deno_task_shell/src/parser.rs	49.62%	67 Missing ⚠️
crates/deno_task_shell/src/shell/command.rs	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
- Coverage   63.55%   58.06%   -5.49%     
==========================================
  Files          28       28              
  Lines        2261     2795     +534     
==========================================
+ Hits         1437     1623     +186     
- Misses        824     1172     +348     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[prsabahrami]

@wolfv @certik Let me know how you think about the way AST is being created here. Then I can proceed with the execution.

[wolfv]

To me, this looks great!

[prsabahrami]

Great! Then I'll proceed with execution and take care of the unwraps.

[prsabahrami]

This seems to be working. I have added support for almost everything except ++ and -- operators. Those are also easy to implement. Will take care of them afterwards.

[Hofer-Julian]

A few minor comments

[Hofer-Julian]

Suggested change

	.map_err(|e| miette!(e.to_string()))?;
	.into_diagnostics()?;

Does this work as well?

[wolfv]

I found like one little thing when testing.

A=5
echo $((1+A))
# doesn't work
echo $((1+$A))
echo $((1+${A}))

Not sure how hard that is. Not super important IMO!

[prsabahrami]

I found like one little thing when testing.

A=5

echo $((1+A))

# doesn't work

echo $((1+$A))

echo $((1+${A}))

Not sure how hard that is. Not super important IMO!

Thanks for pointing this out. If the behaviour in such cases is going to be the same as the first working example, then handling these would a slight modification to the parser if I'm not mistaken.

[wolfv]

yep, definitely the same. Although with the ${A:1:2} syntax you could do additional things in the future (cf #148).

And then in the bash case, things like $((${A}1+1)) would also work but are probably annoying to support.

╭─wolfv@pixi ~/Programs/shell ‹support_arithmetic●›
╰─$ echo $A                                                                                                                                                                                                                                             
5
╭─wolfv@pixi ~/Programs/shell ‹support_arithmetic●›
╰─$ echo $((${A}5+1))
56

[prsabahrami]

Cool. I'll look into those and add support for. But, I also think we can add support for those after #148 is merged so that we'd take care of everything altogether. Let me know what you think!
Also, in regards to the bash examples, if the separator is { or }, it shouldn't be that hard. We can look into those later since I don't think they are in priority.