fix: replace shell syntax in run() calls with shellRun() and Node APIs#100
Closed
TerminalGravity wants to merge 1 commit intomainfrom
Closed
fix: replace shell syntax in run() calls with shellRun() and Node APIs#100TerminalGravity wants to merge 1 commit intomainfrom
TerminalGravity wants to merge 1 commit intomainfrom
Conversation
Fixes #89 — several tools passed shell operators (pipes, redirects, ||) to run() which uses execFileSync (no shell), causing silent failures. Changes: - Add shellRun() to git.ts using execSync with shell: true - token-audit: use fs.readFileSync/statSync instead of wc -l/wc -c - verify-completion: use shellRun for tsc/build/test commands - enrich-agent-task: use shellRun for git ls-files | grep pipelines - scope-work: use shellRun for grep pipelines, array args for git - session-handoff: use shellRun for command -v and gh CLI Closes #89
This was referenced Mar 5, 2026
Collaborator
Author
|
Closing — superseded by #116 which covers all files with the cleaner three-tier approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #89
Several tools passed shell operators (pipes, redirects,
||,2>/dev/null) torun()which usesexecFileSync(no shell), causing silent failures.Changes:
shellRun()togit.ts— usesexecSyncwithshell: truefor commands needing pipes/redirectstoken-audit.ts: replacedwc -l/wc -cwithfs.readFileSync/statSync(Node APIs > shell)verify-completion.ts:shellRunfor tsc, build, and test commandsenrich-agent-task.ts:shellRunforgit ls-files | greppipelinesscope-work.ts:shellRunfor grep pipelines, array args for simple git commandssession-handoff.ts:shellRunforcommand -vandghCLIAll 43 tests pass, clean build.