fix: shell syntax bugs in what-changed, checkpoint, session-health#109
Closed
TerminalGravity wants to merge 1 commit intomainfrom
Closed
fix: shell syntax bugs in what-changed, checkpoint, session-health#109TerminalGravity wants to merge 1 commit intomainfrom
TerminalGravity wants to merge 1 commit intomainfrom
Conversation
run() uses execFileSync (no shell), but what-changed, checkpoint, and session-health were passing shell operators (||, &&, |, 2>/dev/null) and prefixing 'git' in command strings. This caused silent failures since execFileSync passes these as literal git arguments. Fixes: - what-changed: use array args with JS fallback logic - checkpoint: use array args, separate add/commit calls - session-health: use array args, JS string split instead of pipe
This was referenced Mar 5, 2026
Collaborator
Author
|
Closing — superseded by #116 which covers all files with the cleaner three-tier approach. |
This was referenced Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
run()was refactored to useexecFileSync(no shell), but several tool files still pass shell syntax (||,&&,|,2>/dev/null) and prefixgitin command strings. This causes these tools to silently fail —execFileSyncpasses shell operators as literal git arguments.Fixed in this PR
||fallbacks with JS conditional logic using array args&&commands into separaterun()calls with array argsgit diff --stat | tail -1with array args + JS.split().pop()Still affected (see #17)
~8 more tool files have the same issue: verify-completion, token-audit, clarify-intent, session-handoff, audit-workspace, enrich-agent-task, scope-work, sequence-tasks.
All tests pass, clean build.